Re: [PATCH] x86/xen: fix arbitrary_virt_to_machine()

From: Jeremy Fitzhardinge
Date: Fri May 16 2008 - 09:01:19 EST


Ingo Molnar wrote:
unsigned int level;
pte_t *pte = lookup_address(address, &level);
- unsigned offset = address & PAGE_MASK;
+ unsigned offset = address & ~PAGE_SIZE;

Ah, no, you have the worst of both worlds there ;) Should be ~PAGE_*MASK*.

J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/