Re: [PATCH] x86: Get irq for hpet timer

[Balaji Rao R]

On Fri, May 16, 2008 at 11:35 AM, Kevin Hao <kexin.hao@xxxxxxxxxxxxx> wrote:
>
> Hi,
>
> x86: get irq for hpet timer
>
> HPET timer's IRQ is 0 by default, so we have to select which irq
> will be used for these timers. We wait to set the timer's irq until
> we really turn on interrupt in order to reduce the chance of
> conflicting with some legacy device.
>
Yes, this is alright. But  i've seen some machines where we have a
valid IRQ in 'devp->hd_hdwirq' which you should not ignore. So, first
check if it is zero and only then do a hpet_timer_get_irq.

--
warm regards

Balaji Rao
NITK Surathkal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/