Re: [PATCH] modules: Use a better scheme for refcounting

From: Eric Dumazet
Date: Fri May 16 2008 - 00:44:20 EST


Andi Kleen a écrit :
Eric Dumazet <dada1@xxxxxxxxxxxxx> writes:
Instead of wasting NR_CPUS*128 bytes (on i386), we now use
num_possible_cpus*sizeof(local_t) bytes.

On a typical distro, where NR_CPUS=8,

More typical would be NR_CPUS=128, with NR_CPUS=four digits when Mike Travis et.al. are finished

Yes. With NR_CPUS=4096, we save about half a megabyte per module. (!!!)

shiping 2000 modules, we reduce

Surely only the loaded modules count? Perhaps 20-30.

Well, I should have stated that this saving also takes place in the module disk file.
(The "struct module" is included in it, in the ".gnu.linkonce.this_module" section)
Here on my distro, around 2000 modules are shiped.
But it's a cool improvement. Very nice.
Thanks




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/