Re: [BUG] mm: bdi: export BDI attributes in sysfs

[Greg KH]

On Thu, May 15, 2008 at 12:54:57PM -0700, Linus Torvalds wrote:
> 
> 
> On Thu, 15 May 2008, Miklos Szeredi wrote:
> > 
> > Actually nothing should need protection.  The only problem AFAICS is
> > that the device_create()/dev_set_drvdata() interface is racy: somebody
> > can come in after the device has been created but before drvdata has
> > been set, and then we are in trouble.
> 
> Well, I'm not sure that the locking should be at that level. Maybe the 
> locking *should* be in the driver that does this. It may need to do other 
> setup too, after all.
> 
> Of course, doing a device_create_drvdata() thing might be the right 
> solution, at least part of the time. Greg?

Yes, you are right, let me go knock that together...

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/