Re: [PATCH 2/9] HID: make a bus from hid code

[Marcel Holtmann]

Hi Jiri,

> >> +static struct hid_driver hid_generic_bt = {
> >> +	.name = "hid-generic-bt",
> >> +	.id_table = hid_generic_bt_ids,
> >> +};
> > 
> > And this one to hidp_driver instead of hid_generic_bt.
> > 
> > Also the name "hid-generic-bt" is not okay. Call it "hidp" since that is
> > the driver name. An alternative would be "hid-bluetooth". I don't like
> > the "generic" part and we never used the shortcut "bt" in any sysfs
> > visible file.
> 
> Thanks for comments, I fixed all those except this one. The generic- word is 
> tested in the core to recognize generic drivers which bind non-blacklisted 
> devices and are handled separately. Anyway I've renamed them to 
> generic-bluetooth and generic-usb instead of hid-generic-{bt,usb}.
> 
> I think the generic word in the driver name is OK, so that one ordinary user 
> can see, my device is handled by the generic driver without special 
> processing. Would you rather see some flag or something?

actually generic-usb and generic-bluetooth sound perfectly fine to me.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/