Re: [PATCH 1/3] net: handle errors from device_rename

From: Wang Chen
Date: Thu May 15 2008 - 04:44:22 EST


Stephen Hemminger said the following on 2008-5-15 9:15:
> rollback:
> - device_rename(&dev->dev, dev->name);
> + err = device_rename(&dev->dev, dev->name);
> + if (err) {
> + memcpy(dev->name, oldname, IFNAMSIZ);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
no need, dev->name didn't change in device_rename().

> + return err;
> + }
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/