Re: [PATCH 1/1] [usb/host]: use get/put_unaligned_* helpers to fix more potential unaligned issues.

From: Oliver Neukum
Date: Thu May 15 2008 - 03:41:35 EST


Am Donnerstag 15 Mai 2008 08:19:24 schrieb Bryan Wu:
> --- a/drivers/usb/host/uhci-hub.c
> +++ b/drivers/usb/host/uhci-hub.c
> @@ -253,7 +253,7 @@ static int uhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue,
> ÂÂÂÂÂÂÂÂswitch (typeReq) {
> Â
> ÂÂÂÂÂÂÂÂcase GetHubStatus:
> -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ*(__le32 *)buf = cpu_to_le32(0);
> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂput_unaligned_le32(0, buf);

What is supposed to make all these changes a good idea?

Regards
Oliver

N‹§²æìr¸›yúèšØb²X¬¶ÇvØ^–)Þ{.nÇ+‰·¥Š{±‘êçzX§¶›¡Ü}©ž²ÆzÚ&j:+v‰¨¾«‘êçzZ+€Ê+zf£¢·hšˆ§~†­†Ûiÿûàz¹®w¥¢¸?™¨è­Ú&¢)ßf”ù^jÇy§m…á@A«a¶Úÿ 0¶ìh®å’i