Re: [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB fixes for 2.6.26

[Mauro Carvalho Chehab]

On Wed, 14 May 2008, Trent Piepho wrote:

> On Wed, 14 May 2008, Adrian Bunk wrote:
> > > It would be nice if you could help on fixing those issues.
> > >
> > > One dependency that will probably solve is to add "depends on VIDEO_MEDIA &&
> > > I2C" to all devices that are hybrid (bttv, saa7134, cx88, pvrusb, em28xx).
> >
> > What about converting all dependencies on I2C to select's?
>
> Doesn't that just increase the problems with failing to have correct
> dependencies?  Anything that selects I2C needs to depend on everything I2C
> depends on.

True. Currently, the only dependency is this one:

menuconfig I2C
        tristate "I2C support"
        depends on HAS_IOMEM

HAS_IOMEM is true on every architecture, except usermode linux (um) and 
s390. Also, Multimedia menu is already dependent of HAS_IOMEM, so, this 
currently won't add any extra complexity.

I agree that this may add an extra issue to concern, since future changes 
at I2C dependencies will need to be addressed.

--
Cheers,
Mauro Carvalho Chehab
http://linuxtv.org
mchehab@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/