Re: [PATCH] OSS trident: switch from ->write_proc

[Alexey Dobriyan]

On Wed, May 14, 2008 at 08:47:08AM +0300, Muli Ben-Yehuda wrote:
> Thanks Alexey, some comments below. This patch is a step in the right
> direction but I'm afraid it's currently broken.
> 
> On Wed, May 14, 2008 at 01:05:44AM +0400, Alexey Dobriyan wrote:
> 
> > @@ -4441,11 +4446,8 @@ trident_probe(struct pci_dev *pci_dev, const struct pci_device_id *pci_id)
> >  		/* ALi SPDIF OUT function */
> >  		if (card->revision == ALI_5451_V02) {
> >  			ali_setup_spdif_out(card, ALI_PCM_TO_SPDIF_OUT);
> > -			res = create_proc_entry("ALi5451", 0, NULL);
> > -			if (res) {
> > -				res->write_proc = ali_write_proc;
> > -				res->data = card;
> > -			}
> > +			proc_create_data("ALi5451", 0, NULL,
> > +					 &ali_proc_fops, card);
> >  		}
> >  
> >  		/* Add H/W Volume Control By Matt Wu Jul. 06, 2001 */
> 
> This is not enough--we need to also remove the proc_entry if
> trident_probe() fails (see label `out_proc_fs'), which will require
> checking if proc_create_data() succeeded. Please send an updated patch
> or let me know and I'll take care of it.

Sorry, I just want to remove ->write_proc totally and auditing proc
users are for later.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/