Re: [PATCH] fec_mpc52xx: MPC52xx_MESSAGES_DEFAULT: 2nd NETIF_MSG_IFDOWN=> IFUP

[Sylvain Munaut]

Roel Kluin wrote:
>> Yes but I remember seeing a patch for this already ... What kernel
>> version / revision do you have ?
>>
>> Sylvain
>>     
>
> Indeed I already sent the patch, see http://lkml.org/lkml/2008/1/30/252 (my
> emailaddress changed), but there was no response and the patch isn't included in
> current Linus' git. maybe if you could add your ack?
>   

Sure thing.

Acked-by: Sylvain Munaut <tnt@xxxxxxxxxx>

> ---
> duplicate NETIF_MSG_IFDOWN, 2nd should be NETIF_MSG_IFUP
>
> Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx>
> ---
> diff --git a/drivers/net/fec_mpc52xx.c b/drivers/net/fec_mpc52xx.c
> index 5f9c42e..329edd9 100644
> --- a/drivers/net/fec_mpc52xx.c
> +++ b/drivers/net/fec_mpc52xx.c
> @@ -78,7 +78,7 @@ module_param_array_named(mac, mpc52xx_fec_mac_addr, byte, NULL, 0);
>  MODULE_PARM_DESC(mac, "six hex digits, ie. 0x1,0x2,0xc0,0x01,0xba,0xbe");
>  
>  #define MPC52xx_MESSAGES_DEFAULT ( NETIF_MSG_DRV | NETIF_MSG_PROBE | \
> -		NETIF_MSG_LINK | NETIF_MSG_IFDOWN | NETIF_MSG_IFDOWN )
> +		NETIF_MSG_LINK | NETIF_MSG_IFDOWN | NETIF_MSG_IFUP)
>  static int debug = -1;	/* the above default */
>  module_param(debug, int, 0);
>  MODULE_PARM_DESC(debug, "debugging messages level");
>
>   

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/