RE: [PATCH 1/1] infiniband/hw/nes/: avoid unnecessary memset

From: Faisal Latif
Date: Tue May 13 2008 - 18:02:39 EST


Acked-by Faisal Latif<faisal@xxxxxxxxxxxxx>

Thanks
Faisal


>
> From: Christophe Jaillet <christophe.jaillet@xxxxxxxxxx>
>
> Hi, here is a patch against linux/drivers/infiniband/hw/nes/nes_cm.c
> which :
>
> 1) Remove an explicit memset(.., 0, ...) to a variable allocated with
> kzalloc (i.e. 'listener').
>
>
> Note: this patch is based on 'linux-2.6.25.tar.bz2'
>
> Signed-off-by: Christophe Jaillet <christophe.jaillet@xxxxxxxxxx>
>
> ---
>
> --- linux/drivers/infiniband/hw/nes/nes_cm.c 2008-04-17
> 04:49:44.000000000 +0200
> +++ linux/drivers/infiniband/hw/nes/nes_cm.c.cj 2008-05-12
> 23:31:24.000000000 +0200
> @@ -1587,7 +1587,6 @@ static struct nes_cm_listener *mini_cm_l
> return NULL;
> }
>
> - memset(listener, 0, sizeof(struct nes_cm_listener));
> listener->loc_addr = htonl(cm_info->loc_addr);
> listener->loc_port = htons(cm_info->loc_port);
> listener->reused_node = 0;
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/