Re: [PATCH 1/1] [MTD/MAPS] Blackfin Async Flash Maps: Handle the case where flash memory and ethernet mac/phy are mapped onto the same async bank

From: JÃrn Engel
Date: Tue May 13 2008 - 15:16:47 EST


On Tue, 13 May 2008 13:42:04 -0400, Mike Frysinger wrote:
> On Tue, May 13, 2008 at 11:34 AM, JÃrn Engel <joern@xxxxxxxxx> wrote:
> > On Tue, 13 May 2008 12:38:45 +0800, Bryan Wu wrote:
> > > +#define pr_devinit(fmt, args...) ({ static const __devinitdata char __fmt[] = fmt; printk(__fmt, ## args); })
> >
> > That bit is obvious. But why do you use pr_devinit() instead of
> > printk()? What does it gain you?
>
> why do we have __init and __devinit in the first place ?

Ah. Now I finally understand what this code does.

Might be worth moving it to include/linux/kernel.h, along with
pr_init(). And watch an avalanche of janitor patches use these new
toys. :)

JÃrn

--
Joern's library part 3:
http://inst.eecs.berkeley.edu/~cs152/fa05/handouts/clark-test.pdf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/