Re: [PATCH 1/1] [MTD/MAPS] Blackfin Async Flash Maps: Handle the case where flash memory and ethernet mac/phy are mapped onto the same async bank

[JÃrn Engel]

On Tue, 13 May 2008 11:15:57 -0400, Mike Frysinger wrote:
> On Tue, May 13, 2008 at 11:01 AM, JÃrn Engel wrote:
> > On Tue, 13 May 2008 08:42:08 -0400, Mike Frysinger wrote:
> >  > On Tue, May 13, 2008 at 4:07 AM, JÃrn Engel wrote:
> >  > > On Tue, 13 May 2008 12:38:45 +0800, Bryan Wu wrote:
> >  > >  >
> >  > >  > +#define pr_devinit(fmt, args...) ({ static const __devinitdata char __fmt[] = fmt; printk(__fmt, ## args); })
> >  > >
> >  > >  Is this still needed?
> >  >
> >  > yes
> >
> >  Can you elaborate a bit?
> 
> it's still used, therefore the definition cannot be dropped.  just
> look at the probe function.

That bit is obvious.  But why do you use pr_devinit() instead of
printk()?  What does it gain you?

JÃrn

-- 
Das Aufregende am Schreiben ist es, eine Ordnung zu schaffen, wo
vorher keine existiert hat.
-- Doris Lessing
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/