Re: [RFC/PATCH] printk: detect incomplete lines

[Vegard Nossum]

On Tue, May 13, 2008 at 12:54 PM, Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:
> "Vegard Nossum" <vegard.nossum@xxxxxxxxx> writes:
>  >
>  > Iirc, KERN_CONT is mostly an annotation for the checkpatch script to
>  > suppress the warning about missing loglevel token.
>
>  Perhaps it should be fixed to contain some magic token that is
>  then detected by printk and handled appropiately? And then perhaps
>  employee some kernel janitors to add it everywhere?
>
>  I think that would be preferable over any heuristics as implemented
>  in your original patch because there might be a legitimate need to
>  get out non full line printks ASAP for debugging.

I'm sorry, I don't understand what you mean. My original patch does
not delay anything. My original patch simply inserts a newline before
the next printk() if the caller is different and the current line is
unterminated.

What would be the purpose of the magic token? Please explain.


Vegard

-- 
"The animistic metaphor of the bug that maliciously sneaked in while
the programmer was not looking is intellectually dishonest as it
disguises that the error is the programmer's own creation."
	-- E. W. Dijkstra, EWD1036
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/