Re: [PATCH 1/1] [net/irda]: Fix a misalign access issue.

[Bryan Wu]

On Tue, May 13, 2008 at 12:14 PM, David Miller <davem@xxxxxxxxxxxxx> wrote:
> From: "Yang, Graf" <Graf.Yang@xxxxxxxxxx>
>  Date: Tue, 13 May 2008 12:07:35 +0800
>
>
>  > I have tried
>  > struct irda_device_info {
>  >         __u32       saddr;    /* Address of local interface */
>  >         __u32       daddr;    /* Address of remote device */
>  >         char        info[22]; /* Description */
>  >         __u8        charset;  /* Charset used for description */
>  >         __u8        reserve;  /* For align data */
>  >         __u8        hints[2]; /* Hint bits */
>  > };
>  >
>  > It works with my irda driver. Can I modify it like this?
>
>  This header file and the irda_device_info datastructure are exported
>  to, and used by, userspace.
>
>  Therefore you cannot change this structure's layout without breaking
>  every single existing IRDA binary out there.
>

Exactly, so we plan to add put/get_unaligned method to fix this issue.
After Graf fix it, I will send out the patch

Thanks
-Bryan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/