Re: [PATCH 18/18] flag parameters: check magic constants

From: David Miller
Date: Tue May 13 2008 - 00:39:44 EST


From: Ulrich Drepper <drepper@xxxxxxxxxx>
Date: Mon, 12 May 2008 21:21:29 -0700

> Is MIPS really a problem? The value is 0x80. 128 protocol types should
> be enough. Even if not, there is no reason why the numbers should be
> consecutive. It's easy enough to skip over a bit. I.e., after procotol
> 0x7f the next one would be 0x100.

Indeed, MIPS looks good.

> And PA seems to have gotten O_NONBLOCK wrong. SPARC does it right AFAICS.

I agree.

But that value is compiled into every parisc binary out there,
limiting what we can do about it in the short term.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/