Re: [PATCH 1/1] [INPUT/KEYPAD] gpio keypad: Replace current blackfin specific pfbutton driver with kernel generic gpio key driver

[David Brownell]

On Monday 12 May 2008, Bryan Wu wrote:
>                         unsigned int type = button->type ?: EV_KEY;
> +                       GPIOKEYS_EDGE_SENSE(0);
>                         int state = (gpio_get_value(gpio) ? 1 : 0) ^ button->active_low;
> -
> +                       GPIOKEYS_EDGE_SENSE(1);

By the way ... don't intersperse declarations like "int state"
with code like what those EDGE_SENSE macros wraps...

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/