Re: [PATCH] x86: wakeup.lds.S - section ordering fix

From: Pavel Machek
Date: Mon May 12 2008 - 09:53:26 EST


On Sun 2008-05-11 22:46:38, Cyrill Gorcunov wrote:
> To allow linker to catch sections overlapping we have to declare
> them in appropriate order.
>
> Signed-off-by: Cyrill Gorcunov <gorcunov@xxxxxxxxx>
> ---
>
> Please test and review

Looks okay to me, but I can't easily test it right now.

But I think Rafael tested identical patch, you can add my ACK in such
case.

Pavel

> Index: linux-2.6.git/arch/x86/kernel/acpi/realmode/wakeup.lds.S
> ===================================================================
> --- linux-2.6.git.orig/arch/x86/kernel/acpi/realmode/wakeup.lds.S 2008-05-11 20:21:58.000000000 +0400
> +++ linux-2.6.git/arch/x86/kernel/acpi/realmode/wakeup.lds.S 2008-05-11 22:34:42.000000000 +0400
> @@ -12,11 +12,6 @@ ENTRY(_start)
>
> SECTIONS
> {
> - . = HEADER_OFFSET;
> - .header : {
> - *(.header)
> - }
> -
> . = 0;
> .text : {
> *(.text*)
> @@ -50,6 +45,11 @@ SECTIONS
> __bss_end = .;
> }
>
> + . = HEADER_OFFSET;
> + .header : {
> + *(.header)
> + }
> +
> . = ALIGN(16);
> _end = .;
>

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/