Re: [patch 15/21] Filesystem: XFS slab defragmentation

From: Christoph Hellwig
Date: Sat May 10 2008 - 02:56:19 EST


On Fri, May 09, 2008 at 08:08:46PM -0700, Christoph Lameter wrote:
> + kmem_cache_setup_defrag(xfs_vnode_zone, get_inodes, kick_inodes);

So you're exporting get_inodes and kick_inodes just to use it in always
the same way. Much better to have a kmem_cache_set_inode_defrag helper
and keep them static in inode.c

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/