Re: [patch 6/6] x86: Add checks for virtual addresses in __phys_addr()

[Christoph Lameter]

On Sat, 10 May 2008, Sam Ravnborg wrote:

 > Should this have read:
> > +extern unsigned long __phys_addr(unsigned long x);
> ?
> 
> Looks like a prototype with a missing ';'.
> And x86 uses extern for prototypes in .h files (most of the time).
> 

Right. And this means that I did not test a 32 bit config with 
CONFIG_VM_DEBUG on this one. The run of the mill stuff did not do it. 
Sigh.

This patch fixes the compile:

---
 include/asm-x86/page_32.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6/include/asm-x86/page_32.h
===================================================================
--- linux-2.6.orig/include/asm-x86/page_32.h	2008-05-09 19:32:47.000000000 -0700
+++ linux-2.6/include/asm-x86/page_32.h	2008-05-09 19:32:55.000000000 -0700
@@ -65,7 +65,7 @@ typedef struct page *pgtable_t;
 
 #ifndef __ASSEMBLY__
 #ifdef CONFIG_DEBUG_VM
-unsigned long __phys_addr(unsigned long x)
+extern unsigned long __phys_addr(unsigned long x);
 #else
 #define __phys_addr(x)	((x) - PAGE_OFFSET)
 #endif

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/