Re: [PATCH 5/9] frv: gdb-stub.c use the common ascii hex helpers

[Harvey Harrison]

On Fri, 2008-05-09 at 13:07 +0100, David Howells wrote:
> Harvey Harrison <harvey.harrison@xxxxxxxxx> wrote:
> 
> > Everyone rolls their own version around the tree, centralize
> > in lib/hexdump.c
> 
> Can you instruct that these are only to be used for GDB stubs?  Otherwise if
> someone slaps a breakpoint in there accidentally, they might kill the GDB
> stub.
> 

This isn't a problem for hex_asc_{hi|lo} obviously, just the
hexchar_to_int function, I've been looking at making this available in
another way due to its similarity to simple_strtol etc (akpm noticed).

So the hex_asc_hi/lo helpers are probably useful as-is.  I'll make
sure to note the effects on gdb as you've pointed out when I send
out the revised usage.

Cheers,

Harvey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/