Re: [PATCH] sparsemem vmemmap: initialize memmap.

[Heiko Carstens]

On Fri, May 09, 2008 at 09:25:41AM -0700, Christoph Lameter wrote:
> Nack. vmemmap_alloc_block does 
> 
> void * __meminit vmemmap_alloc_block(unsigned long size, int node)
> {
>         /* If the main allocator is up use that, fallback to bootmem. */
>         if (slab_is_available()) {
>                 struct page *page = alloc_pages_node(node,
>                                 GFP_KERNEL | __GFP_ZERO, get_order(size));
>                 if (page)
>                         return page_address(page);
>                 return NULL;
>         } else
>                 return __earlyonly_bootmem_alloc(node, size, size,
>                                 __pa(MAX_DMA_ADDRESS));
> }
> 
> memory is always zeroed. Maybe you use an alternate implementation that is 
> broken?

Yes, I missed the __GFP_ZERO. Already figured out and fixed in arch code.

Thanks ;)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/