Re: [PATCH 0/3] ia64: Migrate data off physical pages with correctableerrors v3

[Linus Torvalds]

On Fri, 9 May 2008, Russ Anderson wrote:
> 
>   [2/3] page.discard.v2: Avoid putting a bad page back on the LRU.
> 
> 	page.discard are the arch independent changes.  It adds a new
> 	page flag (PG_memerror) to mark the page as bad and prevent it
> 	from being put back on the LRU.  PG_memerror is only defined
> 	on 64 bit architectures. 

So I haven't looked at this a lot, but it strikes me that it look to be 
much simple if you were to just increment the page count instead of 
playing games in mm/page_alloc.c.

That will make sure that it never goes back on any free lists, and 
requires no changes to the allocator. Hmm?

I'm also not really seeing why this triggers on lru_cache_add(), since 
that should only happen to new pages anyway. Who does lru_cache_add() on 
old pages?

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/