Re: [PATCH 3/3] module: don't ignore vermagic string if moduledoesn't have modversions

From: Linus Torvalds
Date: Fri May 09 2008 - 10:45:41 EST




On Fri, 9 May 2008, Rusty Russell wrote:
>
> We should only ignore the start of the vermagic string if the module
> actually *has* crcs to check. Rather than (say) having an
> entertaining hissy fit and creating a config option to work around the
> buggy code.

Btw, this makes the two vesions of "same_magic()" be basically the same
(since without MODVERSIONS, has_crcs *should* always be zero). Maybe we
should make it just one version, to simplify logic?

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/