Re: [PATCH] m32r: use generic sys_pipe

From: Hirokazu Takata
Date: Fri May 09 2008 - 09:38:08 EST


Hi, Christoph,

Please sign off this patch.

Thanks,

From: Christoph Hellwig <hch@xxxxxx>
Subject: [PATCH] m32r: use generic sys_pipe
Date: Fri, 09 May 2008 14:44:02 +0200
> m32r can use the generic sys_pipe implementation.
>
> The current sys_pipe implementation on m32r only differes from the
> generic one by passing a lot of additional unused registers to sys_pipe.
>
> Reviewed and tested by Hirokazu Takata.

Signed-off-by: Hirokazu Takata <takata@xxxxxxxxxxxxxx>

> Index: linux-2.6/arch/m32r/kernel/sys_m32r.c
> ===================================================================
> --- linux-2.6.orig/arch/m32r/kernel/sys_m32r.c 2008-05-09 12:44:10.000000000 +0200
> +++ linux-2.6/arch/m32r/kernel/sys_m32r.c 2008-05-09 12:44:16.000000000 +0200
> @@ -76,29 +76,6 @@ asmlinkage int sys_tas(int __user *addr)
> return oldval;
> }
>
> -/*
> - * sys_pipe() is the normal C calling standard for creating
> - * a pipe. It's not the way Unix traditionally does this, though.
> - */
> -asmlinkage int
> -sys_pipe(unsigned long r0, unsigned long r1, unsigned long r2,
> - unsigned long r3, unsigned long r4, unsigned long r5,
> - unsigned long r6, struct pt_regs regs)
> -{
> - int fd[2];
> - int error;
> -
> - error = do_pipe(fd);
> - if (!error) {
> - if (copy_to_user((void __user *)r0, fd, 2*sizeof(int))) {
> - sys_close(fd[0]);
> - sys_close(fd[1]);
> - error = -EFAULT;
> - }
> - }
> - return error;
> -}
> -
> asmlinkage long sys_mmap2(unsigned long addr, unsigned long len,
> unsigned long prot, unsigned long flags,
> unsigned long fd, unsigned long pgoff)
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/