Re: [PATCH] memory hotplug: memmap_init_zone called twice.

From: KAMEZAWA Hiroyuki
Date: Fri May 09 2008 - 02:31:54 EST


On Fri, 9 May 2008 08:04:25 +0200
Heiko Carstens <heiko.carstens@xxxxxxxxxx> wrote:

> Subject: [PATCH] memory hotplug: memmap_init_zone called twice.
>
> From: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
>
> __add_zone calls memmap_init_zone twice if memory gets attached to
> an empty zone. Once via init_currently_empty_zone and once explictly
> right after that call.
> Looks like this is currently not a bug, however the call is
> superfluous and might lead to subtle bugs if memmap_init_zone gets
> changed. So make sure it is called only once.
>
seems reasonable. Thank you!

Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/