Re: [PATCH 08 of 11] anon-vma-rwsem

From: Linus Torvalds
Date: Thu May 08 2008 - 11:10:57 EST




On Thu, 8 May 2008, Andrea Arcangeli wrote:
>
> Actually I looked both at the struct and at the slab alignment just in
> case it was changed recently. Now after reading your mail I also
> compiled it just in case.

Put the flag after the spinlock, not after the "list_head".

Also, we'd need to make it

unsigned short flag:1;

_and_ change spinlock_types.h to make the spinlock size actually match the
required size (right now we make it an "unsigned int slock" even when we
actually only use 16 bits). See the

#if (NR_CPUS < 256)

code in <asm-x86/spinlock.h>.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/