Re: [PATCH] call_usermodehelper_setup() should use GFP_KERNEL

[KOSAKI Motohiro]

> > > Are you sure? I found the following call chain:
> > > 
> > >   static irqreturn_t power_handler(int irq, void *dev_id)
> > >   ->orderly_poweroff(true);
> > >     ->call_usermodehelper_setup()
> > 
> > sorry, you are right.
> > I'll make patch again.
> 
> How many times do we have to make this mistake :(
> 
> Only the caller knows what allocation mode the callee can use. 
> call_usermodehelper_setup() should be extended to take a gfp_t argument.

Agreed.
I'm testing so patch.
I'll post tommorow, myabe.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/