Re: [Linux-fbdev-devel] [PATCH 2/9] viafb: VIA Frame Buffer Device Driver

[Ondrej Zajicek]

On Wed, May 07, 2008 at 07:09:28PM +0800, JosephChan@xxxxxxxxxx wrote:
> +u16 red256[] = {
> +	0x0, 0x0, 0x0, 0x0, 0xa800, 0xa800, 0xa800, 0xa800, 0x5400, 0x5400,
> +	0x5400, 0x5400, 0xfc00, 0xfc00, 0xfc00, 0xfc00,

...

> +u16 green256[] =
> +    { 0x0, 0x0, 0xa800, 0xa800, 0x0, 0x0, 0x5400, 0xa800, 0x5400, 0x5400,
> +	0xfc00, 0xfc00, 0x5400, 0x5400, 0xfc00, 0xfc00,

...

> +};
> +u16 blue256[] =
> +    { 0x0, 0xa800, 0x0, 0xa800, 0x0, 0xa800, 0x0, 0xa800, 0x5400, 0xfc00,
> +	0x5400, 0xfc00, 0x5400, 0xfc00, 0x5400, 0xfc00,
> +	0x0, 0x1400, 0x2000, 0x2c00, 0x3800, 0x4400, 0x5000, 0x6000,

...

> +};
> +
> +struct fb_cmap viafb_256_colors = { 0, 256, red256, green256, blue256, NULL

Standard pattern is to allocate colormap using fb_alloc_cmap(). This function
also fills colormap with common default colormap. It is unnecessary to have
another default colormap.

-- 
Elen sila lumenn' omentielvo

Ondrej 'SanTiago' Zajicek (email: santiago@xxxxxxxxxxxxx)
OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
"To err is human -- to blame it on a computer is even more so."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/