Re: microblaze syscall list

From: Arnd Bergmann
Date: Sun May 04 2008 - 15:37:47 EST


On Sunday 04 May 2008, Michal Simek wrote:

> > mremap is a duplicate, you only need it once ;-)
>
> There are mixed mmu and nommu version - brk, munmap, mrepap are in both version
> but they take from different files.

That doesn't matter as the kernel is only ever built with one of the
two files. My point was just that you should have only one entry
in the syscall table if you generate it from your list.

> > right. sys_pipe and sys_mmap2 should probably go to fs/pipe.c and mm/mmap.c, but
> > that does not need to be your worry right now, it's not part of the ABI.
>
> YES. sys_pipe was remove from all arch today. Patches from Uli. I'll remove
> sys_pipe from our sys_microblaze.c.

Ah, cool. I guess this leaves sys_mmap2, which we'll take care of eventually.

> Here is updated syscall table.

Thanks, looks good. I'd love to get a second opinion on the list though,
it's quite likely that I made a mistake somewhere.

Just three more calls I found:

> ok .long sys_unlinkat
> ok .long sys_unlink

> ok .long sys_linkat
> ok .long sys_link

> ok .long sys_chown
> ok .long sys_fchownat

For all of these, you only need the *at variant, afaict.

Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/