Re: [patch] video: build fix for drivers/media/video/mt9v022.c

From: Ingo Molnar
Date: Sat May 03 2008 - 15:51:40 EST



* Guennadi Liakhovetski <g.liakhovetski@xxxxxx> wrote:

> Ok, right, sorry, the patch was indeed correct, just the reason for
> the compilation breakage was not quite what you suggested. So, I'll
> apply your putch, but please fix mt9m001.c in the same patch too - it
> also includes gpio.h conditionally. Although, it does test the correct
> macro.
>
> Actually, this CONFIG option might disappear completely in the future,
> if we decide to switch to a module parameter instead. So that one
> kernel can be used on systems with and without the GPIO.

ok - untested patch for mt9m001.c attached.

Ingo

Index: linux/drivers/media/video/mt9m001.c
===================================================================
--- linux.orig/drivers/media/video/mt9m001.c
+++ linux/drivers/media/video/mt9m001.c
@@ -12,15 +12,12 @@
#include <linux/slab.h>
#include <linux/i2c.h>
#include <linux/log2.h>
+#include <linux/gpio.h>

#include <media/v4l2-common.h>
#include <media/v4l2-chip-ident.h>
#include <media/soc_camera.h>

-#ifdef CONFIG_MT9M001_PCA9536_SWITCH
-#include <asm/gpio.h>
-#endif
-
/* mt9m001 i2c address 0x5d
* The platform has to define i2c_board_info
* and call i2c_register_board_info() */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/