Re: [PATCH 07/10] net: fix returning void-valued expressionwarnings

[Linus Torvalds]

On Wed, 30 Apr 2008, Harvey Harrison wrote:
> 
> Well, in an X86_32 allyesconfig, this only trips 32 times...so it's not
> exactly common.  I agree that there is nothing _wrong_ with this, I'll
> just add Linus and see if we can just call it codingstyle ;)

I actually had a patch to sparse to _not_ complain about it, because I 
think it's one of the sane C++ extensions. I must have lost the patch and 
not sent it upstream.

So in general, I don't mind the "return void_function()" in a void 
function, I think it makes sense from a type standpoint, and sometimes 
results in cleaner code. That said, I'm also not sure it's worth breaking 
the C standard over, so I don't really mind it being fixed in the kernel 
either (but would certainly also not complain if sparse were to be changed 
to not complain)

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/