Re: [spi-devel-general] [PATCH] spi_mpc83xx: test below 0 on unsigned irq in mpc83xx_spi_probe()

From: David Brownell
Date: Wed Apr 30 2008 - 18:12:30 EST


On Wednesday 23 April 2008, Kumar Gala wrote:
>
> On Apr 23, 2008, at 3:19 PM, Roel Kluin wrote:
> > mpc83xx_spi->irq is unsigned, so the test fails
> >
> > Signed-off-by: Roel Kluin <12o3l@xxxxxxxxxx>

Any reason to not just make mpc83xx_spi->irq be "int",
following normal practice everywhere? If not, I'll
roll that into the patch from Joakim Tjernlund...

- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/