Re: [patch] inlining: do not allow gcc below version 4 to optimize inlining

From: Sam Ravnborg
Date: Wed Apr 30 2008 - 15:57:47 EST


On Wed, Apr 30, 2008 at 10:03:07PM +0300, Adrian Bunk wrote:
> > /*
> > - * Force always-inline if the user requests it so via the .config:
> > + * Force always-inline if the user requests it so via the .config,
> > + * or if gcc is too old:
> > */
> > #if !defined(CONFIG_ARCH_SUPPORTS_OPTIMIZED_INLINING) || \
> > - !defined(CONFIG_OPTIMIZE_INLINING) && (__GNUC__ >= 4)
>
> One moment.
>
> Let me try to understand what we currently have in the tree.
>
> This *always* enables the so called "optimized inlining" for the older
> compilers we did *not* wanted to have this for.
>
> Even with CONFIG_OPTIMIZE_INLINING=n .
>
> How was this reviewed and tested?

I for one reviewed this.
No I did not catch the obvious bug and
feel free to flame me for that.

Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/