Re: [PATCH] quota: Add a convenience macro for filesystems

[Andrew Morton]

On Wed, 30 Apr 2008 17:06:18 +0200
Jan Kara <jack@xxxxxxx> wrote:

> Note that it cannot be an inline function because we don't have struct
> super_block prototype...
> 

lame excuse ;)

> ---
>  include/linux/quota.h |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/quota.h b/include/linux/quota.h
> index 52e49dc..dcddfb2 100644
> --- a/include/linux/quota.h
> +++ b/include/linux/quota.h
> @@ -347,6 +347,9 @@ struct quota_info {
>  	((type) == USRQUOTA ? (sb_dqopt(sb)->flags & DQUOT_USR_SUSPENDED) : \
>  			      (sb_dqopt(sb)->flags & DQUOT_GRP_SUSPENDED))
>  
> +#define sb_any_quota_suspended(sb) (sb_has_quota_suspended(sb, USRQUOTA) | \
> +				  sb_has_quota_suspended(sb, GRPQUOTA))
> +
>  int register_quota_format(struct quota_format_type *fmt);
>  void unregister_quota_format(struct quota_format_type *fmt);


Here's a fun exercise:

	sb = sb_orig;
	sb_any_quota_suspended(sb++);
	printk("%d\n", sb - sb_orig);

afaict this will print 44 or thereabouts.

ho hum.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/