Re: [patch, -git] media/video/sound build fix, TEA5761/TEA5767

[Takashi Iwai]

At Wed, 30 Apr 2008 13:01:15 +0200,
Ingo Molnar wrote:
> 
> 
> x86.git randconfig testing found the following new build error in latest 
> -git:
> 
>  drivers/built-in.o: In function `v4l2_i2c_drv_attach_legacy':
>  tuner-core.c:(.text+0x1a829d): undefined reference to `v4l2_i2c_attach'
>  drivers/built-in.o: In function `tuner_command':
>  tuner-core.c:(.text+0x1a971c): undefined reference to `v4l_printk_ioctl'
> 
> the reason appears to be that the TEA5761/TEA5767 tuner code is 
> dependent on (legacy?) V4L infrastructure like v4l2_i2c_attach, by 
> virtue of drivers/media/video/tuner-core.c including 
> media/v4l2-i2c-drv-legacy.h and ./sound/i2c/other/Makefile doing:
> 
>   snd-tea575x-tuner-objs := tea575x-tuner.o
> 
> for now i solved this via adding a VIDEO_V4L2_COMMON dependency to 
> MEDIA_TUNER - which solves the build problem by excluding these drivers 
> - but i suspect there might be a better fix as well that does not 
> restrict the selectability of these drivers.

IMO, it's the reverse selection from sound to V4L that makes things
complicated.  I believe it's better to fix it as a normal dependency.

How about the patch below?


Takashi


Fix kconfig dependency mess of fm801-tea575x

FM801-tea575x tuner has a reverse selection to V4L1 and this causes
dependency problem.  The patch simplifies the dependency with a
normal depend on VIDEO_V4L1.

Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>
---

diff --git a/sound/pci/Kconfig b/sound/pci/Kconfig
index 581debf..7e47421 100644
--- a/sound/pci/Kconfig
+++ b/sound/pci/Kconfig
@@ -515,19 +515,16 @@ config SND_FM801
 config SND_FM801_TEA575X_BOOL
 	bool "ForteMedia FM801 + TEA5757 tuner"
 	depends on SND_FM801
+	depends on VIDEO_V4L1=y || VIDEO_V4L1=SND_FM801
 	help
 	  Say Y here to include support for soundcards based on the ForteMedia
 	  FM801 chip with a TEA5757 tuner connected to GPIO1-3 pins (Media
 	  Forte SF256-PCS-02) into the snd-fm801 driver.
 
-	  This will enable support for the old V4L1 API.
-
 config SND_FM801_TEA575X
 	tristate
 	depends on SND_FM801_TEA575X_BOOL
 	default SND_FM801
-	select VIDEO_V4L1
-	select VIDEO_DEV
 
 config SND_HDA_INTEL
 	tristate "Intel HD Audio"
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/