Re: Announce: Semaphore-Removal tree

From: Matthew Wilcox
Date: Wed Apr 30 2008 - 06:06:36 EST


On Tue, Apr 29, 2008 at 10:09:30AM +1000, David Chinner wrote:
> > 2. l_flushsema
> >
> > This seems to be a completion. ie you're using it to wait for the log
> > to be flushed.
>
> Yes, that could probably be a completion. I'm assuming that a completion
> can handle several thousand waiting processes, right?

By the way ... is it common that you get several thousand waiting
processes? I ask because you wake them all up, then the herd thunders
into the l_icloglock spinlock. Or is this a worst-case scenario that
happens once in a blue moon?

If l_flushsema does typically get more than one waiter, we can instead
wake the waiters one at a time.

--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/