Re: [PATCH 1/2] x86: mtrr cleanup for converting continuous to discrete layout v7

From: Yinghai Lu
Date: Tue Apr 29 2008 - 23:01:21 EST

Next message: Randy.Dunlap: "[PATCH] docbook: fix fatal rapidio yet again (and more to come)"
Previous message: Theodore Ts'o: "[GIT PULL] ext4 update"
In reply to: Gabriel C: "Re: [PATCH 1/2] x86: mtrr cleanup for converting continuous to discretelayout v7"
Next in thread: Yinghai Lu: "Re: [PATCH 1/2] x86: mtrr cleanup for converting continuous to discrete layout v7"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Tue, Apr 29, 2008 at 6:02 PM, Gabriel C <nix.or.die@xxxxxxxxxxxxxx> wrote:
>
> Yinghai Lu wrote:
> > On Tue, Apr 29, 2008 at 5:06 PM, Gabriel C <nix.or.die@xxxxxxxxxxxxxx> wrote:
> >> Gabriel C wrote:
> >> > Yinghai Lu wrote:
> >> >> On Tue, Apr 29, 2008 at 1:25 PM, Gabriel C <nix.or.die@xxxxxxxxxxxxxx> wrote:
> >> >>> Yinghai Lu wrote:
> >> >>> > On Tue, Apr 29, 2008 at 4:51 AM, Gabriel C <nix.or.die@xxxxxxxxxxxxxx> wrote:
> >> >>> >> Yinghai Lu wrote:
> >> >>> >> > On Tue, Apr 29, 2008 at 3:30 AM, Yinghai Lu <yhlu.kernel@xxxxxxxxx> wrote:
> >> >>> >> >> On Tue, Apr 29, 2008 at 2:47 AM, Gabriel C <nix.or.die@xxxxxxxxxxxxxx> wrote:
> >> >>> >> >> > Yinghai Lu wrote:
> >> >>> >> >> > > some BIOS like to use continus MTRR layout, and may X driver can not add
> >> >>> >> >> > > WB entries for graphical cards when 4g or more RAM installed.
> >> >>> >> >> > >
> >> >>> >> >> > > the patch will change MTRR to discrete.
> >> >>> >> >> > >
> >> >>> >> >> > > mtrr_chunk_size= could be used to have smaller continuous block to hold holes.
> >> >>> >> >> > > default is 256m, could be set according to size of graphics card memory.
> >> >>> >> >> > >
> >> >>> >> >> > > v2: fix -1 for UC checking
> >> >>> >> >> > > v3: default to disable, and need use enable_mtrr_cleanup to enable this feature
> >> >>> >> >> > > skip the var state change warning.
> >> >>> >> >> > > remove next_basek in range_to_mtrr()
> >> >>> >> >> > > v4: correct warning mask.
> >> >>> >> >> > > v5: CONFIG_MTRR_SANITIZER
> >> >>> >> >> > > v6: fix 1g, 2g, 512 aligment with extra hole
> >> >>> >> >> > > v7: gran_sizek to prevent running out of MTRRs.
> >> >>> >> >> > >
> >> >>> >> >> >
> >> >>> >> >> > With this version ( and patch http://lkml.org/lkml/2008/4/29/97 ) applyed on latest linus git tree
> >> >>> >> >> > the box OOPS'es early.
> >> >>> >> >> >
> >> >>> >> >> > Sorry I don't have time right now to write down the part of the OOPS I can see on monitor , I can try to find
> >> >>> >> >> > some time later.
> >> >>> >> >> >
> >> >>> >> >> > In any way OOPS'es on __free_one_page+0x191/0x21e
> >> >>> >> >>
> >> >>> >> >> thanks. found one problem with hole_basek ...
> >> >>> >> >>
> >> >>> >> >> will send you v8, and hope it will be last version.
> >> >>> >> >
> >> >>> >> > please try v8, it should get rid of the 8m entry. it need patch
> >> >>> >> > http://lkml.org/lkml/2008/4/29/97 too.
> >> >>> >>
> >> >>> >> Box does boot with v8 but now I get that warning you fixed in v2 again =):
> >> >>> >>
> >> >>> >> ....
> >> >>> >> [ 0.000000] Linux version 2.6.25-06058-ga01e035-dirty (crazy@thor) (gcc version 4.3.0 (Frugalware Linux) ) #805 SMP PREEMPT Tue Apr 29 13:04:49 CEST 2008
> >> >>> >> [ 0.000000] Command line: root=/dev/sdb1 ro debug vga=0x317
> >> >>> >> [ 0.000000] BIOS-provided physical RAM map:
> >> >>> >> [ 0.000000] BIOS-e820: 0000000000000000 - 000000000009cc00 (usable)
> >> >>> >> [ 0.000000] BIOS-e820: 000000000009cc00 - 00000000000a0000 (reserved)
> >> >>> >> [ 0.000000] BIOS-e820: 00000000000e4000 - 0000000000100000 (reserved)
> >> >>> >> [ 0.000000] BIOS-e820: 0000000000100000 - 00000000cf550000 (usable)
> >> >>> >> [ 0.000000] BIOS-e820: 00000000cf550000 - 00000000cf55e000 (ACPI data)
> >> >>> >> [ 0.000000] BIOS-e820: 00000000cf55e000 - 00000000cf5e0000 (ACPI NVS)
> >> >>> >> [ 0.000000] BIOS-e820: 00000000cf5e0000 - 00000000cf600000 (reserved)
> >> >>> >> [ 0.000000] BIOS-e820: 00000000fee00000 - 00000000fee01000 (reserved)
> >> >>> >> [ 0.000000] BIOS-e820: 00000000ffc00000 - 0000000100000000 (reserved)
> >> >>> >> [ 0.000000] BIOS-e820: 0000000100000000 - 000000012c000000 (usable)
> >> >>> >> [ 0.000000] Entering add_active_range(0, 0, 156) 0 entries of 256 used
> >> >>> >> [ 0.000000] Entering add_active_range(0, 256, 849232) 1 entries of 256 used
> >> >>> >> [ 0.000000] Entering add_active_range(0, 1048576, 1228800) 2 entries of 256 used
> >> >>> >> [ 0.000000] max_pfn_mapped = 1228800
> >> >>> >> [ 0.000000] x86 PAT enabled: cpu 0, old 0x7040600070406, new 0x7010600070106
> >> >>> >> [ 0.000000] After WB checking
> >> >>> >> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 000000000012c000
> >> >>> >> [ 0.000000] After UC checking
> >> >>> >> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cf600
> >> >>> >> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000
> >> >>> >> [ 0.000000] MTRR MAP PFN: 00000000000cf800 - 00000000000d0000
> >> >>> >> [ 0.000000] After sorting
> >> >>> >> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cf600
> >> >>> >> [ 0.000000] MTRR MAP PFN: 00000000000cf800 - 00000000000d0000
> >> >>> >> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000
> >> >>> >> [ 0.000000] range0: 0000000000000000 - 00000000c0000000
> >> >>> >> [ 0.000000] Setting variable MTRR 0, base: 0MB, range: 2048MB, type WB
> >> >>> >> [ 0.000000] Setting variable MTRR 1, base: 2048MB, range: 1024MB, type WB
> >> >>> >> [ 0.000000] range: 00000000c0000000 - 00000000d0000000
> >> >>> >> [ 0.000000] Setting variable MTRR 2, base: 3072MB, range: 256MB, type WB
> >> >>> >> [ 0.000000] hole: 00000000cc000000 - 00000000d0000000
> >> >>> >> [ 0.000000] Setting variable MTRR 3, base: 3264MB, range: 64MB, type UC
> >> >>> >> [ 0.000000] rangeX: 00000000d0000000 - 00000000d0000000
> >> >>> >> [ 0.000000] range0: 0000000100000000 - 0000000120000000
> >> >>> >> [ 0.000000] Setting variable MTRR 4, base: 4096MB, range: 512MB, type WB
> >> >>> >> [ 0.000000] range: 0000000120000000 - 0000000130000000
> >> >>> >> [ 0.000000] Setting variable MTRR 5, base: 4608MB, range: 256MB, type WB
> >> >>> >> [ 0.000000] hole: 000000012c000000 - 0000000130000000
> >> >>> >> [ 0.000000] Setting variable MTRR 6, base: 4800MB, range: 64MB, type UC
> >> >>> >> [ 0.000000] DONE variable MTRRs
> >> >>> >> [ 0.000000] x86 PAT enabled: cpu 0, old 0x7010600070106, new 0x7010600070106
> >> >>> >> [ 0.000000] After WB checking
> >> >>> >> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000d0000
> >> >>> >> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 0000000000130000
> >> >>> >> [ 0.000000] After UC checking
> >> >>> >> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cc000
> >> >>> >> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000
> >> >>> >> [ 0.000000] After sorting
> >> >>> >> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cc000
> >> >>> >> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000
> >> >>> >> [ 0.000000] WARNING: BIOS bug: CPU MTRRs don't cover all of memory, losing 757MB of RAM.
> >> >>> >
> >> >>> > so
> >> >>> >> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cf600
> >> >>> >> [ 0.000000] MTRR MAP PFN: 00000000000cf800 - 00000000000d0000
> >> >>> >> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000
> >> >>> > ===>
> >> >>> >> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cc000
> >> >>> >> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000
> >> >>> >
> >> >>> > please try
> >> >>>
> >> >>> Now I have 2 warnings
> >> >>>
> >> >>>
> >> >>> > mtrr_chunk_size=512m mtrr_gran_size=128m
> >> >>>
> >> >>> ...
> >> >>>
> >> >>> [ 0.000000] Command line: root=/dev/sdb1 ro debug vga=0x317 mtrr_chunk_size=512m mtrr_gran_size=128m 3
> >> >>>
> >> >>>
> >> >>> [ 0.000000] BIOS-provided physical RAM map:
> >> >>> [ 0.000000] BIOS-e820: 0000000000000000 - 000000000009cc00 (usable)
> >> >>> [ 0.000000] BIOS-e820: 000000000009cc00 - 00000000000a0000 (reserved)
> >> >>> [ 0.000000] BIOS-e820: 00000000000e4000 - 0000000000100000 (reserved)
> >> >>> [ 0.000000] BIOS-e820: 0000000000100000 - 00000000cf550000 (usable)
> >> >>> [ 0.000000] BIOS-e820: 00000000cf550000 - 00000000cf55e000 (ACPI data)
> >> >>> [ 0.000000] BIOS-e820: 00000000cf55e000 - 00000000cf5e0000 (ACPI NVS)
> >> >>> [ 0.000000] BIOS-e820: 00000000cf5e0000 - 00000000cf600000 (reserved)
> >> >>> [ 0.000000] BIOS-e820: 00000000fee00000 - 00000000fee01000 (reserved)
> >> >>> [ 0.000000] BIOS-e820: 00000000ffc00000 - 0000000100000000 (reserved)
> >> >>> [ 0.000000] BIOS-e820: 0000000100000000 - 000000012c000000 (usable)
> >> >>> [ 0.000000] Entering add_active_range(0, 0, 156) 0 entries of 256 used
> >> >>> [ 0.000000] Entering add_active_range(0, 256, 849232) 1 entries of 256 used
> >> >>> [ 0.000000] Entering add_active_range(0, 1048576, 1228800) 2 entries of 256 used
> >> >>> [ 0.000000] max_pfn_mapped = 1228800
> >> >>> [ 0.000000] x86 PAT enabled: cpu 0, old 0x7040600070406, new 0x7010600070106
> >> >>> [ 0.000000] After WB checking
> >> >>> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 000000000012c000
> >> >>> [ 0.000000] After UC checking
> >> >>> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cf600
> >> >>> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000
> >> >>> [ 0.000000] MTRR MAP PFN: 00000000000cf800 - 00000000000d0000
> >> >>> [ 0.000000] After sorting
> >> >>> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cf600
> >> >>> [ 0.000000] MTRR MAP PFN: 00000000000cf800 - 00000000000d0000
> >> >>> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000
> >> >>> [ 0.000000] range0: 0000000000000000 - 00000000c0000000
> >> >>> [ 0.000000] Setting variable MTRR 0, base: 0MB, range: 2048MB, type WB
> >> >>> [ 0.000000] Setting variable MTRR 1, base: 2048MB, range: 1024MB, type WB
> >> >>> [ 0.000000] range: 00000000c0000000 - 00000000c8000000
> >> >>> [ 0.000000] Setting variable MTRR 2, base: 3072MB, range: 128MB, type WB
> >> >>>
> >> >>> [ 0.000000] rangeX: 00000000d0000000 - 00000000d0000000
> >> >>> [ 0.000000] range0: 0000000100000000 - 0000000120000000
> >> >>> [ 0.000000] Setting variable MTRR 3, base: 4096MB, range: 512MB, type WB
> >> >>> [ 0.000000] range: 0000000120000000 - 0000000128000000
> >> >>> [ 0.000000] Setting variable MTRR 4, base: 4608MB, range: 128MB, type WB
> >> >>>
> >> >>> [ 0.000000] DONE variable MTRRs
> >> >>> [ 0.000000] x86 PAT enabled: cpu 0, old 0x7010600070106, new 0x7010600070106
> >> >>> [ 0.000000] After WB checking
> >> >>> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000c8000
> >> >>> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 0000000000128000
> >> >>>
> >> >>> [ 0.000000] After UC checking
> >> >>> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000c8000
> >> >>> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 0000000000128000
> >> >>> [ 0.000000] After sorting
> >> >>> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000c8000
> >> >>> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 0000000000128000
> >> >>> [ 0.000000] WARNING: BIOS bug: CPU MTRRs don't cover all of memory, losing 64MB of RAM.
> >> >>> [ 0.000000] ------------[ cut here ]------------
> >> >>> [ 0.000000] WARNING: at arch/x86/kernel/cpu/mtrr/main.c:1206 mtrr_trim_uncached_memory+0x25b/0x35a()
> >> >>>
> >> >>> [ 0.000000] Modules linked in:
> >> >>> [ 0.000000] Pid: 0, comm: swapper Not tainted 2.6.25-06058-ga01e035-dirty #805
> >> >>> [ 0.000000]
> >> >>> [ 0.000000] Call Trace:
> >> >>> [ 0.000000] [<ffffffff8022d661>] warn_on_slowpath+0x51/0x78
> >> >>> [ 0.000000] [<ffffffff8067f0dc>] x86_get_mtrr_mem_range+0x241/0x25c
> >> >>> [ 0.000000] [<ffffffff8067d93e>] update_memory_range+0x95/0xb7
> >> >>> [ 0.000000] [<ffffffff8067fa51>] mtrr_trim_uncached_memory+0x25b/0x35a
> >> >>>
> >> >>> [ 0.000000] [<ffffffff8067ca43>] setup_arch+0x280/0x4a2
> >> >>> [ 0.000000] [<ffffffff80676aa6>] start_kernel+0x6e/0x308
> >> >>> [ 0.000000] [<ffffffff80676432>] x86_64_start_kernel+0x241/0x24a
> >> >>> [ 0.000000]
> >> >>> [ 0.000000] ---[ end trace ca143223eefdc828 ]---
> >> >>> [ 0.000000] update e820 for mtrr -- end_pfn
> >> >>> [ 0.000000] modified physical RAM map:
> >> >>> [ 0.000000] modified: 0000000000000000 - 000000000009cc00 (usable)
> >> >>> [ 0.000000] modified: 000000000009cc00 - 00000000000a0000 (reserved)
> >> >>> [ 0.000000] modified: 00000000000e4000 - 0000000000100000 (reserved)
> >> >>> [ 0.000000] modified: 0000000000100000 - 00000000cf550000 (usable)
> >> >>> [ 0.000000] modified: 00000000cf550000 - 00000000cf55e000 (ACPI data)
> >> >>> [ 0.000000] modified: 00000000cf55e000 - 00000000cf5e0000 (ACPI NVS)
> >> >>> [ 0.000000] modified: 00000000cf5e0000 - 00000000cf600000 (reserved)
> >> >>> [ 0.000000] modified: 00000000fee00000 - 00000000fee01000 (reserved)
> >> >>> [ 0.000000] modified: 00000000ffc00000 - 0000000100000000 (reserved)
> >> >>> [ 0.000000] modified: 0000000100000000 - 0000000128000000 (usable)
> >> >>> [ 0.000000] modified: 0000000128000000 - 000000012c000000 (reserved)
> >> >>>
> >> >>> [ 0.000000] WARNING: BIOS bug: CPU MTRRs don't cover all of memory, losing 757MB of RAM.
> >> >>>
> >> >>> [ 0.000000] ------------[ cut here ]------------
> >> >>> [ 0.000000] WARNING: at arch/x86/kernel/cpu/mtrr/main.c:1227 mtrr_trim_uncached_memory+0x30c/0x35a()
> >> >>> [ 0.000000] Modules linked in:
> >> >>> [ 0.000000] Pid: 0, comm: swapper Not tainted 2.6.25-06058-ga01e035-dirty #805
> >> >>> [ 0.000000]
> >> >>> [ 0.000000] Call Trace:
> >> >>> [ 0.000000] [<ffffffff8022d661>] warn_on_slowpath+0x51/0x78
> >> >>> [ 0.000000] [<ffffffff8067f0dc>] x86_get_mtrr_mem_range+0x241/0x25c
> >> >>> [ 0.000000] [<ffffffff8067d93e>] update_memory_range+0x95/0xb7
> >> >>> [ 0.000000] [<ffffffff8067fb02>] mtrr_trim_uncached_memory+0x30c/0x35a
> >> >>> [ 0.000000] [<ffffffff8067ca43>] setup_arch+0x280/0x4a2
> >> >>> [ 0.000000] [<ffffffff80676aa6>] start_kernel+0x6e/0x308
> >> >>> [ 0.000000] [<ffffffff80676432>] x86_64_start_kernel+0x241/0x24a
> >> >>> [ 0.000000]
> >> >>> [ 0.000000] ---[ end trace ca143223eefdc828 ]---
> >> >>> [ 0.000000] update e820 for mtrr -- holes
> >> >>> [ 0.000000] modified physical RAM map:
> >> >>> [ 0.000000] modified: 0000000000000000 - 000000000009cc00 (usable)
> >> >>> [ 0.000000] modified: 000000000009cc00 - 00000000000a0000 (reserved)
> >> >>> [ 0.000000] modified: 00000000000e4000 - 0000000000100000 (reserved)
> >> >>> [ 0.000000] modified: 0000000000100000 - 00000000c8000000 (usable)
> >> >>> [ 0.000000] modified: 00000000c8000000 - 00000000cf550000 (reserved)
> >> >>> [ 0.000000] modified: 00000000cf550000 - 00000000cf55e000 (ACPI data)
> >> >>> [ 0.000000] modified: 00000000cf55e000 - 00000000cf5e0000 (ACPI NVS)
> >> >>> [ 0.000000] modified: 00000000cf5e0000 - 00000000cf600000 (reserved)
> >> >>> [ 0.000000] modified: 00000000fee00000 - 00000000fee01000 (reserved)
> >> >>> [ 0.000000] modified: 00000000ffc00000 - 000000012c000000 (reserved)
> >> >>>
> >> >>> [ 0.000000] Entering add_active_range(0, 0, 156) 3 entries of 256 used
> >> >>> [ 0.000000] Entering add_active_range(0, 256, 819200) 3 entries of 256 used
> >> >> please try attached trim_holes_fix.patch..., it will fix the trim hole problem.
> >> >
> >> > Tested but warning is still there. I try to boot with mtrr_chunk_size / mtrr_gran_size and see what I get.
> >> >
> >> > ...
> >> >
> >> > [ 0.000000] Linux version 2.6.25-06589-gc65a350-dirty (crazy@thor) (gcc version 4.3.0 (Frugalware Linux) ) #808 SMP PREEMPT Wed Apr 30 01:37:38 CEST 2008
> >> > [ 0.000000] Command line: root=/dev/sdb1 ro debug vga=0x317
> >> > [ 0.000000] BIOS-provided physical RAM map:
> >> > [ 0.000000] BIOS-e820: 0000000000000000 - 000000000009cc00 (usable)
> >> > [ 0.000000] BIOS-e820: 000000000009cc00 - 00000000000a0000 (reserved)
> >> > [ 0.000000] BIOS-e820: 00000000000e4000 - 0000000000100000 (reserved)
> >> > [ 0.000000] BIOS-e820: 0000000000100000 - 00000000cf550000 (usable)
> >> > [ 0.000000] BIOS-e820: 00000000cf550000 - 00000000cf55e000 (ACPI data)
> >> > [ 0.000000] BIOS-e820: 00000000cf55e000 - 00000000cf5e0000 (ACPI NVS)
> >> > [ 0.000000] BIOS-e820: 00000000cf5e0000 - 00000000cf600000 (reserved)
> >> > [ 0.000000] BIOS-e820: 00000000fee00000 - 00000000fee01000 (reserved)
> >> > [ 0.000000] BIOS-e820: 00000000ffc00000 - 0000000100000000 (reserved)
> >> > [ 0.000000] BIOS-e820: 0000000100000000 - 000000012c000000 (usable)
> >> > [ 0.000000] Entering add_active_range(0, 0, 156) 0 entries of 256 used
> >> > [ 0.000000] Entering add_active_range(0, 256, 849232) 1 entries of 256 used
> >> > [ 0.000000] Entering add_active_range(0, 1048576, 1228800) 2 entries of 256 used
> >> > [ 0.000000] max_pfn_mapped = 1228800
> >> > [ 0.000000] x86 PAT enabled: cpu 0, old 0x7040600070406, new 0x7010600070106
> >> > [ 0.000000] After WB checking
> >> > [ 0.000000] MTRR MAP PFN: 0000000000000000 - 000000000012c000
> >> > [ 0.000000] After UC checking
> >> > [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cf600
> >> > [ 0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000
> >> > [ 0.000000] MTRR MAP PFN: 00000000000cf800 - 00000000000d0000
> >> > [ 0.000000] After sorting
> >> > [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cf600
> >> > [ 0.000000] MTRR MAP PFN: 00000000000cf800 - 00000000000d0000
> >> > [ 0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000
> >> > [ 0.000000] range0: 0000000000000000 - 00000000c0000000
> >> > [ 0.000000] Setting variable MTRR 0, base: 0MB, range: 2048MB, type WB
> >> > [ 0.000000] Setting variable MTRR 1, base: 2048MB, range: 1024MB, type WB
> >> > [ 0.000000] range: 00000000c0000000 - 00000000d0000000
> >> > [ 0.000000] Setting variable MTRR 2, base: 3072MB, range: 256MB, type WB
> >> > [ 0.000000] hole: 00000000cc000000 - 00000000d0000000
> >> > [ 0.000000] Setting variable MTRR 3, base: 3264MB, range: 64MB, type UC
> >> > [ 0.000000] rangeX: 00000000d0000000 - 00000000d0000000
> >> > [ 0.000000] range0: 0000000100000000 - 0000000120000000
> >> > [ 0.000000] Setting variable MTRR 4, base: 4096MB, range: 512MB, type WB
> >> > [ 0.000000] range: 0000000120000000 - 0000000130000000
> >> > [ 0.000000] Setting variable MTRR 5, base: 4608MB, range: 256MB, type WB
> >> > [ 0.000000] hole: 000000012c000000 - 0000000130000000
> >> > [ 0.000000] Setting variable MTRR 6, base: 4800MB, range: 64MB, type UC
> >> > [ 0.000000] DONE variable MTRRs
> >> > [ 0.000000] x86 PAT enabled: cpu 0, old 0x7010600070106, new 0x7010600070106
> >> > [ 0.000000] After WB checking
> >> > [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000d0000
> >> > [ 0.000000] MTRR MAP PFN: 0000000000100000 - 0000000000130000
> >> > [ 0.000000] After UC checking
> >> > [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cc000
> >> > [ 0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000
> >> > [ 0.000000] After sorting
> >> > [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cc000
> >> > [ 0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000
> >> > [ 0.000000] WARNING: BIOS bug: CPU MTRRs don't cover all of memory, losing 757MB of RAM.
> >> > [ 0.000000] ------------[ cut here ]------------
> >> > [ 0.000000] WARNING: at arch/x86/kernel/cpu/mtrr/main.c:1227 mtrr_trim_uncached_memory+0x313/0x361()
> >> > [ 0.000000] Modules linked in:
> >> > [ 0.000000] Pid: 0, comm: swapper Not tainted 2.6.25-06589-gc65a350-dirty #808
> >> > [ 0.000000]
> >> > [ 0.000000] Call Trace:
> >> > [ 0.000000] [<ffffffff8022d699>] warn_on_slowpath+0x51/0x8c
> >> > [ 0.000000] [<ffffffff806810b4>] x86_get_mtrr_mem_range+0x241/0x25c
> >> > [ 0.000000] [<ffffffff8067f915>] update_memory_range+0x95/0xb7
> >> > [ 0.000000] [<ffffffff80681ae1>] mtrr_trim_uncached_memory+0x313/0x361
> >> > [ 0.000000] [<ffffffff8067ea16>] setup_arch+0x280/0x4a6
> >> > [ 0.000000] [<ffffffff80678a3d>] start_kernel+0x6e/0x30d
> >> > [ 0.000000] [<ffffffff80678432>] x86_64_start_kernel+0x241/0x24a
> >> > [ 0.000000]
> >> > [ 0.000000] ---[ end trace 4eaa2a86a8e2da22 ]---
> >> > [ 0.000000] update e820 for mtrr -- holes
> >> > [ 0.000000] modified physical RAM map:
> >> > [ 0.000000] modified: 0000000000000000 - 000000000009cc00 (usable)
> >> > [ 0.000000] modified: 000000000009cc00 - 00000000000a0000 (reserved)
> >> > [ 0.000000] modified: 00000000000e4000 - 0000000000100000 (reserved)
> >> > [ 0.000000] modified: 0000000000100000 - 00000000cc000000 (usable)
> >> > [ 0.000000] modified: 00000000cc000000 - 00000000cf550000 (reserved)
> >> > [ 0.000000] modified: 00000000cf550000 - 00000000cf55e000 (ACPI data)
> >> > [ 0.000000] modified: 00000000cf55e000 - 00000000cf5e0000 (ACPI NVS)
> >> > [ 0.000000] modified: 00000000cf5e0000 - 00000000cf600000 (reserved)
> >> > [ 0.000000] modified: 00000000fee00000 - 00000000fee01000 (reserved)
> >> > [ 0.000000] modified: 00000000ffc00000 - 000000012c000000 (reserved)
> >> > [ 0.000000] Entering add_active_range(0, 0, 156) 3 entries of 256 used
> >> > [ 0.000000] Entering add_active_range(0, 256, 835584) 3 entries of 256 used
> >> > [ 0.000000] max_pfn_mapped = 1228800
> >> > [ 0.000000] init_memory_mapping
> >> >
> >> > ...
> >> >
> >>
> >> with mtrr_chunk_size=256m mtrr_gran_size=128m I'm getting :
> >>
> >> ...
> >>
> >>
> >>
> >> [ 0.000000] BIOS-provided physical RAM map:
> >> [ 0.000000] BIOS-e820: 0000000000000000 - 000000000009cc00 (usable)
> >> [ 0.000000] BIOS-e820: 000000000009cc00 - 00000000000a0000 (reserved)
> >> [ 0.000000] BIOS-e820: 00000000000e4000 - 0000000000100000 (reserved)
> >> [ 0.000000] BIOS-e820: 0000000000100000 - 00000000cf550000 (usable)
> >> [ 0.000000] BIOS-e820: 00000000cf550000 - 00000000cf55e000 (ACPI data)
> >> [ 0.000000] BIOS-e820: 00000000cf55e000 - 00000000cf5e0000 (ACPI NVS)
> >> [ 0.000000] BIOS-e820: 00000000cf5e0000 - 00000000cf600000 (reserved)
> >> [ 0.000000] BIOS-e820: 00000000fee00000 - 00000000fee01000 (reserved)
> >> [ 0.000000] BIOS-e820: 00000000ffc00000 - 0000000100000000 (reserved)
> >> [ 0.000000] BIOS-e820: 0000000100000000 - 000000012c000000 (usable)
> >> [ 0.000000] Entering add_active_range(0, 0, 156) 0 entries of 256 used
> >> [ 0.000000] Entering add_active_range(0, 256, 849232) 1 entries of 256 used
> >> [ 0.000000] Entering add_active_range(0, 1048576, 1228800) 2 entries of 256 used
> >> [ 0.000000] max_pfn_mapped = 1228800
> >> [ 0.000000] x86 PAT enabled: cpu 0, old 0x7040600070406, new 0x7010600070106
> >> [ 0.000000] After WB checking
> >> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 000000000012c000
> >> [ 0.000000] After UC checking
> >> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cf600
> >> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000
> >> [ 0.000000] MTRR MAP PFN: 00000000000cf800 - 00000000000d0000
> >> [ 0.000000] After sorting
> >> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cf600
> >> [ 0.000000] MTRR MAP PFN: 00000000000cf800 - 00000000000d0000
> >> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000
> >> [ 0.000000] range0: 0000000000000000 - 00000000c0000000
> >> [ 0.000000] Setting variable MTRR 0, base: 0MB, range: 2048MB, type WB
> >> [ 0.000000] Setting variable MTRR 1, base: 2048MB, range: 1024MB, type WB
> >> [ 0.000000] range: 00000000c0000000 - 00000000c8000000
> >> [ 0.000000] Setting variable MTRR 2, base: 3072MB, range: 128MB, type WB
> >> [ 0.000000] rangeX: 00000000d0000000 - 00000000d0000000
> >> [ 0.000000] range0: 0000000100000000 - 0000000120000000
> >> [ 0.000000] Setting variable MTRR 3, base: 4096MB, range: 512MB, type WB
> >> [ 0.000000] range: 0000000120000000 - 0000000128000000
> >> [ 0.000000] Setting variable MTRR 4, base: 4608MB, range: 128MB, type WB
> >> [ 0.000000] DONE variable MTRRs
> >> [ 0.000000] x86 PAT enabled: cpu 0, old 0x7010600070106, new 0x7010600070106
> >> [ 0.000000] After WB checking
> >> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000c8000
> >> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 0000000000128000
> >> [ 0.000000] After UC checking
> >> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000c8000
> >> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 0000000000128000
> >> [ 0.000000] After sorting
> >> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000c8000
> >> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 0000000000128000
> >> [ 0.000000] WARNING: BIOS bug: CPU MTRRs don't cover all of memory, losing 64MB of RAM.
> >> [ 0.000000] ------------[ cut here ]------------
> >> [ 0.000000] WARNING: at arch/x86/kernel/cpu/mtrr/main.c:1206 mtrr_trim_uncached_memory+0x25b/0x361()
> >>
> >> [ 0.000000] Modules linked in:
> >> [ 0.000000] Pid: 0, comm: swapper Not tainted 2.6.25-06589-gc65a350-dirty #808
> >> [ 0.000000]
> >> [ 0.000000] Call Trace:
> >> [ 0.000000] [<ffffffff8022d699>] warn_on_slowpath+0x51/0x8c
> >> [ 0.000000] [<ffffffff806810b4>] x86_get_mtrr_mem_range+0x241/0x25c
> >> [ 0.000000] [<ffffffff8067f915>] update_memory_range+0x95/0xb7
> >> [ 0.000000] [<ffffffff80681a29>] mtrr_trim_uncached_memory+0x25b/0x361
> >>
> >> [ 0.000000] [<ffffffff8067ea16>] setup_arch+0x280/0x4a6
> >> [ 0.000000] [<ffffffff80678a3d>] start_kernel+0x6e/0x30d
> >> [ 0.000000] [<ffffffff80678432>] x86_64_start_kernel+0x241/0x24a
> >> [ 0.000000]
> >> [ 0.000000] ---[ end trace 4eaa2a86a8e2da22 ]---
> >>
> >> [ 0.000000] update e820 for mtrr -- end_pfn
> >> [ 0.000000] modified physical RAM map:
> >> [ 0.000000] modified: 0000000000000000 - 000000000009cc00 (usable)
> >> [ 0.000000] modified: 000000000009cc00 - 00000000000a0000 (reserved)
> >> [ 0.000000] modified: 00000000000e4000 - 0000000000100000 (reserved)
> >> [ 0.000000] modified: 0000000000100000 - 00000000cf550000 (usable)
> >> [ 0.000000] modified: 00000000cf550000 - 00000000cf55e000 (ACPI data)
> >> [ 0.000000] modified: 00000000cf55e000 - 00000000cf5e0000 (ACPI NVS)
> >> [ 0.000000] modified: 00000000cf5e0000 - 00000000cf600000 (reserved)
> >> [ 0.000000] modified: 00000000fee00000 - 00000000fee01000 (reserved)
> >> [ 0.000000] modified: 00000000ffc00000 - 0000000100000000 (reserved)
> >> [ 0.000000] modified: 0000000100000000 - 0000000128000000 (usable)
> >> [ 0.000000] modified: 0000000128000000 - 000000012c000000 (reserved)
> >> [ 0.000000] WARNING: BIOS bug: CPU MTRRs don't cover all of memory, losing 757MB of RAM.
> >> [ 0.000000] ------------[ cut here ]------------
> >>
> >> [ 0.000000] WARNING: at arch/x86/kernel/cpu/mtrr/main.c:1227 mtrr_trim_uncached_memory+0x313/0x361()
> >> [ 0.000000] Modules linked in:
> >> [ 0.000000] Pid: 0, comm: swapper Tainted: G W 2.6.25-06589-gc65a350-dirty #808
> >>
> >> [ 0.000000]
> >> [ 0.000000] Call Trace:
> >> [ 0.000000] [<ffffffff8022d699>] warn_on_slowpath+0x51/0x8c
> >> [ 0.000000] [<ffffffff806810b4>] x86_get_mtrr_mem_range+0x241/0x25c
> >> [ 0.000000] [<ffffffff8067f915>] update_memory_range+0x95/0xb7
> >> [ 0.000000] [<ffffffff80681ae1>] mtrr_trim_uncached_memory+0x313/0x361
> >> [ 0.000000] [<ffffffff8067ea16>] setup_arch+0x280/0x4a6
> >> [ 0.000000] [<ffffffff80678a3d>] start_kernel+0x6e/0x30d
> >> [ 0.000000] [<ffffffff80678432>] x86_64_start_kernel+0x241/0x24a
> >> [ 0.000000]
> >> [ 0.000000] ---[ end trace 4eaa2a86a8e2da22 ]---
> >> [ 0.000000] update e820 for mtrr -- holes
> >> [ 0.000000] modified physical RAM map:
> >> [ 0.000000] modified: 0000000000000000 - 000000000009cc00 (usable)
> >> [ 0.000000] modified: 000000000009cc00 - 00000000000a0000 (reserved)
> >> [ 0.000000] modified: 00000000000e4000 - 0000000000100000 (reserved)
> >>
> >> [ 0.000000] modified: 0000000000100000 - 00000000c8000000 (usable)
> >> [ 0.000000] modified: 00000000c8000000 - 00000000cf550000 (reserved)
> >> [ 0.000000] modified: 00000000cf550000 - 00000000cf55e000 (ACPI data)
> >> [ 0.000000] modified: 00000000cf55e000 - 00000000cf5e0000 (ACPI NVS)
> >> [ 0.000000] modified: 00000000cf5e0000 - 00000000cf600000 (reserved)
> >> [ 0.000000] modified: 00000000fee00000 - 00000000fee01000 (reserved)
> >> [ 0.000000] modified: 00000000ffc00000 - 000000012c000000 (reserved)
> >> [ 0.000000] Entering add_active_range(0, 0, 156) 3 entries of 256 used
> >> [ 0.000000] Entering add_active_range(0, 256, 819200) 3 entries of 256 used
> >>
> > please check attached debug patch...
>
> Here the output :
>
> ...
>
> [ 0.000000] Linux version 2.6.25-06598-g33ae0cd-dirty (crazy@thor) (gcc version 4.3.0 (Frugalware Linux) ) #814 SMP PREEMPT Wed Apr 30 02:47:52 CEST 2008
> [ 0.000000] Command line: root=/dev/sdb1 ro debug vga=0x317 mtrr_chunk_size=256m mtrr_gran_size=128m
>
>
> [ 0.000000] BIOS-provided physical RAM map:
> [ 0.000000] BIOS-e820: 0000000000000000 - 000000000009cc00 (usable)
> [ 0.000000] BIOS-e820: 000000000009cc00 - 00000000000a0000 (reserved)
> [ 0.000000] BIOS-e820: 00000000000e4000 - 0000000000100000 (reserved)
> [ 0.000000] BIOS-e820: 0000000000100000 - 00000000cf550000 (usable)
> [ 0.000000] BIOS-e820: 00000000cf550000 - 00000000cf55e000 (ACPI data)
> [ 0.000000] BIOS-e820: 00000000cf55e000 - 00000000cf5e0000 (ACPI NVS)
> [ 0.000000] BIOS-e820: 00000000cf5e0000 - 00000000cf600000 (reserved)
> [ 0.000000] BIOS-e820: 00000000fee00000 - 00000000fee01000 (reserved)
> [ 0.000000] BIOS-e820: 00000000ffc00000 - 0000000100000000 (reserved)
> [ 0.000000] BIOS-e820: 0000000100000000 - 000000012c000000 (usable)
> [ 0.000000] Entering add_active_range(0, 0, 156) 0 entries of 256 used
> [ 0.000000] Entering add_active_range(0, 256, 849232) 1 entries of 256 used
> [ 0.000000] Entering add_active_range(0, 1048576, 1228800) 2 entries of 256 used
> [ 0.000000] max_pfn_mapped = 1228800
> [ 0.000000] x86 PAT enabled: cpu 0, old 0x7040600070406, new 0x7010600070106
> [ 0.000000] After WB checking
> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 000000000012c000
> [ 0.000000] After UC checking
> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cf600
> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000
> [ 0.000000] MTRR MAP PFN: 00000000000cf800 - 00000000000d0000
> [ 0.000000] After sorting
> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cf600
> [ 0.000000] MTRR MAP PFN: 00000000000cf800 - 00000000000d0000
> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000
> [ 0.000000] range0: 0000000000000000 - 00000000c0000000
> [ 0.000000] Setting variable MTRR 0, base: 0MB, range: 2048MB, type WB
> [ 0.000000] Setting variable MTRR 1, base: 2048MB, range: 1024MB, type WB
> [ 0.000000] range: 00000000c0000000 - 00000000c8000000
> [ 0.000000] Setting variable MTRR 2, base: 3072MB, range: 128MB, type WB
> [ 0.000000] rangeX: 00000000d0000000 - 00000000d0000000
> [ 0.000000] range0: 0000000100000000 - 0000000120000000
> [ 0.000000] Setting variable MTRR 3, base: 4096MB, range: 512MB, type WB
> [ 0.000000] range: 0000000120000000 - 0000000128000000
> [ 0.000000] Setting variable MTRR 4, base: 4608MB, range: 128MB, type WB
> [ 0.000000] DONE variable MTRRs
> [ 0.000000] x86 PAT enabled: cpu 0, old 0x7010600070106, new 0x7010600070106
> [ 0.000000] After WB checking
> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000c8000
> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 0000000000128000
> [ 0.000000] After UC checking
> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000c8000
> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 0000000000128000
> [ 0.000000] After sorting
> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000c8000
> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 0000000000128000
> [ 0.000000] trimm e820 for MTRR MAP (UC): 0000000000128000 - 000000000012c000
>
> [ 0.000000] WARNING: BIOS bug: CPU MTRRs don't cover all of memory, losing 64MB of RAM.
>
> [ 0.000000] update e820 for mtrr -- end_pfn
> [ 0.000000] modified physical RAM map:
> [ 0.000000] modified: 0000000000000000 - 000000000009cc00 (usable)
> [ 0.000000] modified: 000000000009cc00 - 00000000000a0000 (reserved)
> [ 0.000000] modified: 00000000000e4000 - 0000000000100000 (reserved)
> [ 0.000000] modified: 0000000000100000 - 00000000cf550000 (usable)
> [ 0.000000] modified: 00000000cf550000 - 00000000cf55e000 (ACPI data)
> [ 0.000000] modified: 00000000cf55e000 - 00000000cf5e0000 (ACPI NVS)
> [ 0.000000] modified: 00000000cf5e0000 - 00000000cf600000 (reserved)
> [ 0.000000] modified: 00000000fee00000 - 00000000fee01000 (reserved)
> [ 0.000000] modified: 00000000ffc00000 - 0000000100000000 (reserved)
> [ 0.000000] modified: 0000000100000000 - 0000000128000000 (usable)
> [ 0.000000] modified: 0000000128000000 - 000000012c000000 (reserved)
> [ 0.000000] trimm e820 for MTRR MAP (UC): 00000000000c8000 - 0000000000100000
>
> [ 0.000000] WARNING: BIOS bug: CPU MTRRs don't cover all of memory, losing 757MB of RAM.
>
> [ 0.000000] update e820 for mtrr -- holes
> [ 0.000000] modified physical RAM map:
> [ 0.000000] modified: 0000000000000000 - 000000000009cc00 (usable)
> [ 0.000000] modified: 000000000009cc00 - 00000000000a0000 (reserved)
> [ 0.000000] modified: 00000000000e4000 - 0000000000100000 (reserved)
> [ 0.000000] modified: 0000000000100000 - 00000000c8000000 (usable)
> [ 0.000000] modified: 00000000c8000000 - 00000000cf550000 (reserved)
> [ 0.000000] modified: 00000000cf550000 - 00000000cf55e000 (ACPI data)
> [ 0.000000] modified: 00000000cf55e000 - 00000000cf5e0000 (ACPI NVS)
> [ 0.000000] modified: 00000000cf5e0000 - 00000000cf600000 (reserved)
> [ 0.000000] modified: 00000000fee00000 - 00000000fee01000 (reserved)
> [ 0.000000] modified: 00000000ffc00000 - 000000012c000000 (reserved)
> [ 0.000000] Entering add_active_range(0, 0, 156) 3 entries of 256 used
> [ 0.000000] Entering add_active_range(0, 256, 819200) 3 entries of 256 used
>
> [ 0.000000] max_pfn_mapped = 1228800
> [ 0.000000] init_memory_mapping
>
> ...
>
> ( this kernel is still not build with your second cleanup patch will do so in next run )
>
> Also let me know if you want me to boot with any other mtrr_chunk_size / mtrr_gran_size values.
>
i can not find problem with the code, wonder why it trim out
0000000100000000 - 0000000128000000

please try the attached debug patch in addtion to

http://people.redhat.com/mingo/x86.git/README

YH
Index: linux-2.6/arch/x86/kernel/cpu/mtrr/main.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/cpu/mtrr/main.c
+++ linux-2.6/arch/x86/kernel/cpu/mtrr/main.c
@@ -1103,6 +1103,9 @@ static u64 __init real_trim_memory(unsig
trim_size = limit_pfn;
trim_size <<= PAGE_SHIFT;
trim_size -= trim_start;
+
+ printk(KERN_INFO "trim e820 with MTRR MAP (UC): %016lx - %016lx\n", start_pfn, limit_pfn);
+
return update_memory_range(trim_start, trim_size, E820_RAM,
E820_RESERVED);
}
@@ -1124,7 +1127,6 @@ int __init mtrr_trim_uncached_memory(uns
struct res_range range[RANGE_NUM];
int nr_range;
u64 total_real_trim_size;
- int changed;

/* extra one for all 0 */
int num[MTRR_NUM_TYPES + 1];
@@ -1189,49 +1191,35 @@ int __init mtrr_trim_uncached_memory(uns
}
nr_range = x86_get_mtrr_mem_range(range, nr_range, 0, 0);

- changed = 0;
- total_real_trim_size = 0;
-
- /* check the top at first */
- i = nr_range - 1;
- if (range[i].end + 1 < end_pfn) {
- total_real_trim_size += real_trim_memory(range[i].end + 1, end_pfn);
- }
-
- if (total_real_trim_size) {
- printk(KERN_WARNING "WARNING: BIOS bug: CPU MTRRs don't cover"
- " all of memory, losing %lluMB of RAM.\n",
- total_real_trim_size >> 20);
-
- WARN_ON(1);
-
- printk(KERN_INFO "update e820 for mtrr -- end_pfn\n");
- update_e820();
- changed = 1;
- }
-
total_real_trim_size = 0;
+ /* check the head */
if (range[0].start)
total_real_trim_size += real_trim_memory(0, range[0].start);
-
- for (i = 0; i < nr_range - 1; i--) {
+ /* check the holes */
+ for (i = 0; i < nr_range - 1; i++) {
if (range[i].end + 1 < range[i+1].start)
total_real_trim_size += real_trim_memory(range[i].end + 1, range[i+1].start);
}
+ /* check the top */
+ i = nr_range - 1;
+ if (range[i].end + 1 < end_pfn)
+ total_real_trim_size += real_trim_memory(range[i].end + 1, end_pfn);

if (total_real_trim_size) {
printk(KERN_WARNING "WARNING: BIOS bug: CPU MTRRs don't cover"
" all of memory, losing %lluMB of RAM.\n",
total_real_trim_size >> 20);

- WARN_ON(1);
+ if (enable_mtrr_cleanup < 1)
+ WARN_ON(1);

- printk(KERN_INFO "update e820 for mtrr -- holes\n");
+ printk(KERN_INFO "update e820 for mtrr\n");
update_e820();
- changed = 1;
+
+ return 1;
}

- return changed;
+ return 0;
}

/**
Index: linux-2.6/arch/x86/kernel/e820_64.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/e820_64.c
+++ linux-2.6/arch/x86/kernel/e820_64.c
@@ -846,6 +846,8 @@ u64 __init update_memory_range(u64 start
if (ei->addr >= start && ei->size <= size) {
ei->type = new_type;
real_updated_size += ei->size;
+ printk(KERN_INFO "modified physical RAM map - whole cover with %d:\n", i);
+ e820_print_map("modified");
continue;
}
/* partially covered */
@@ -856,6 +858,8 @@ u64 __init update_memory_range(u64 start
add_memory_region(final_start, final_end - final_start,
new_type);
real_updated_size += final_end - final_start;
+ printk(KERN_INFO "modified physical RAM map - add one with %d:\n", i);
+ e820_print_map("modified");
}
return real_updated_size;
}

Next message: Randy.Dunlap: "[PATCH] docbook: fix fatal rapidio yet again (and more to come)"
Previous message: Theodore Ts'o: "[GIT PULL] ext4 update"
In reply to: Gabriel C: "Re: [PATCH 1/2] x86: mtrr cleanup for converting continuous to discretelayout v7"
Next in thread: Yinghai Lu: "Re: [PATCH 1/2] x86: mtrr cleanup for converting continuous to discrete layout v7"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]