Re: [PATCH 1/8] Scaling msgmni to the amount of lowmem

From: Tony Luck
Date: Tue Apr 29 2008 - 16:28:48 EST


On Mon, Feb 11, 2008 at 7:16 AM, <Nadia.Derbey@xxxxxxxx> wrote:
> Index: linux-2.6.24-mm1/ipc/msg.c
> ===================================================================
> --- linux-2.6.24-mm1.orig/ipc/msg.c 2008-02-07 15:02:29.000000000 +0100
> +++ linux-2.6.24-mm1/ipc/msg.c 2008-02-07 15:24:19.000000000 +0100
...
> +out_callback:
> +
> + printk(KERN_INFO "msgmni has been set to %d for ipc namespace %p\n",
> + ns->msg_ctlmni, ns);
> +}

This patch has now made its way to mainline. I can see how this printk
was really useful to you while developing this patch. But does it add
much value in a production system? It just looks like another piece of
clutter on the console to my uncontainerized eyes.

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/