Re: patch driver-core-warn-about-duplicate-driver-names-on-the-same-bus.patchadded to gregkh-2.6 tree

From: Stas Sergeev
Date: Tue Apr 29 2008 - 15:29:00 EST


Hello.

Takashi Iwai wrote:
> Though, I think the snd-pcsp driver could be better built on the top
> of input pcspkr driver, or coexist with it. Then we'll have no more
> conflict about platform name space.
I was trying this in the past.
This never worked out very well.
I disliked the dependancies.
Either snd-pcsp was loading pcspkr,
or there had to be the global variable
to prevent the concurrent access, and
that hurts modularity.

> When you compare input pcspkr.c and sound pcsp_input.c, you can find
> that most of codes are identical.
Yep, its a copy/paste mainly.
I wanted a complete replacement.
Back then, I've been told that multiple
drivers controlling the same device is
never a good idea. But I won't be surprised
if that have changed since. :)

> What we'd need is a hook on
> pcspkr.c that adds a dynamic check whether snd-pcsp (or any ohter)
> is running.
How?
And also, with snd-pcsp you have a
mixer control to disable the beeps,
which I find sometimes even more
usefull than the pcm sound itself. :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/