Re: [27/37] tehuti: move ioctl perm check closer to function start(CVE-2008-1675)

[Alan Cox]

On Tue, 29 Apr 2008 10:19:01 -0700
Greg KH <gregkh@xxxxxxx> wrote:

> 2.6.25-stable review patch.  If anyone has any objections, please let us
> know.
> 
> ------------------
> From: Jeff Garzik <jeff@xxxxxxxxxx>
> 
> Commit f946dffed6334f08da065a89ed65026ebf8b33b4 upstream
> 
> Noticed by davem.
> 
> Signed-off-by: Jeff Garzik <jgarzik@xxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
> 
> ---
>  drivers/net/tehuti.c |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> --- a/drivers/net/tehuti.c
> +++ b/drivers/net/tehuti.c
> @@ -649,6 +649,9 @@ static int bdx_ioctl_priv(struct net_dev
>  		DBG("%d 0x%x 0x%x\n", data[0], data[1], data[2]);
>  	}
>  
> +	if (!capable(CAP_NET_ADMIN))
> +		return -EPERM;
> +

Should be CAP_SYS_RAWIO

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/