Re: [PATCH] bitops: remove "optimizations"

[Thomas Gleixner]

On Tue, 29 Apr 2008, David Miller wrote:
> From: David Miller <davem@xxxxxxxxxxxxx>
> Date: Tue, 29 Apr 2008 03:03:32 -0700 (PDT)
> 
> > From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> > Date: Tue, 29 Apr 2008 12:01:02 +0200 (CEST)
> > 
> > > Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> > 
> > Acked-by: David S. Miller <davem@xxxxxxxxxxxxx>
> 
> Ironically, I just bisected sparc64 bootup failures to the following
> changeset.  It's very late here, and I haven't looked into the
> details, but it seems to wedge in free_area_init_nodes() on a non-NUMA
> system with CONFIG_NUMA disabled.
> 
> Isn't it funny that this optimization not only was useless, but also
> broke things. :-/

The question is, whether it broke things or just unearthed some bug
hidden elsewhere.

Thanks,
	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/