Re: [PATCH] x86: vm86 - hide X86_VM_MASK from userland programs v2

From: H. Peter Anvin
Date: Tue Apr 29 2008 - 11:51:23 EST


Cyrill Gorcunov wrote:
| | with this patch we have <asm/vm86.h> included only
| if __i386__ defined *BUT* X86_VM_MASK is tried to be
| used *without* __386__ being checked (as example - ptrace.h:user_mode_vm).
| I'm not sure how to properly hanle this situation. But will take a look.
| | So I suggest you drop my last patch (which moves X86_VM_MASK
| into __KERNEL__ section) for a while. I'll recheck all
| this stuff later (too busy now).
| | - Cyrill -

Thomas, could you take a look please - is my suspicious wrong?

- Cyrill -

X86_VM_MASK should be defined to zero on x86-64. Part of the reason for this symbol is so we don't have to put #ifdef around its uses.

-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/