Re: [PATCH] toshiba: Use ioremap_cached

From: Andrew Morton
Date: Tue Apr 29 2008 - 11:15:50 EST


On Tue, 29 Apr 2008 16:15:59 +0200 Ingo Molnar <mingo@xxxxxxx> wrote:

>
> * Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:
>
> > The switch of ioremap to default to uncached doesn't break this driver
> > but it does needlessly slow it down as BIOS space is cachable and this
> > driver is quite happy scanning cached ROM space.
> >
> > Signed-off-by: Alan Cox <alan@xxxxxxxxxx>
>
> Acked-by: Ingo Molnar <mingo@xxxxxxx>
>
> i suspect this shouldnt go via x86.git but i've queued it up to track
> it.

Please don't "queue things up to track them". Just queue them up to merge
them, or don't queue them at all.

Because if you queue it up then I will not. If you later for some reason
unqueue it then volia, it is lost. We should aim to avoid having multiple
copies of a patch sitting around the place.

I shall not merge this patch - it is yours.

> Is there an active maintainer for this file?

drivers/char/*? Very rarely maintained. git-whatchanged tells the story
on this one: no.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/