Re: [PATCH] ARCH: Fix 32-bit x86 MSI-X allocation leakage

[Ingo Molnar]

* Waskiewicz Jr, Peter P <peter.p.waskiewicz.jr@xxxxxxxxx> wrote:

> > * PJ Waskiewicz <peter.p.waskiewicz.jr@xxxxxxxxx> wrote:
> > 
> > > This bug was introduced in the 2.6.24 i386/x86_64 tree merge, [...]
> > 
> > that's wrong, that code was there in v2.6.23 too - and it wasnt 
> > touched in the unification. Why do you think it was introduced in 
> > the i386/x86_64 tree merge?
> 
> 2.6.23.17 didn't have the used_vectors bitmap.  The first time I could 
> find it used was in 2.6.24.  Where was the code existing in 2.6.23?  
> The addition may have not been part of the merge, but it was 
> definitely introduced in the same timeframe, meaning the 2.6.24 
> release timeframe.

that change came in via lguest (commit dbeb2be2), not the 32-bit/64-bit 
x86 unification. Lguest is a new feature in 2.6.24 and this side-effect 
of it was not known until you fixed it - thanks for that!

So i was just splitting hairs over your statement that it was due to the 
unification :-)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/