Re: rtc_valid_tm doesn't check tm_wday

From: Uwe Kleine-König
Date: Tue Apr 29 2008 - 08:23:19 EST


Hello Dave,

David Brownell wrote:
> On Monday 28 April 2008, Uwe Kleine-König wrote:
> > Hello,
> >
> > I'm currently writing an rtc driver and want to use rtc_valid_tm to
> > assert to have a valid date before writing it to the rtc.
> >
> > Now I wonder why rtc_valid_tm doesn't check tm_wday for being in the
> > range [0 .. 6]. Is there a reason?
>
> As far as I know, the kernel doesn't use tm_wday, tm_yday, or
> tm_isdst ... so none of those fields are expected to be valid.
> See the rtc(4) manpage.
Thanks.

I still want to write the correct value to the rtc, so I will assert
dirctly in the driver that it's valid.

Best regards,
Uwe

--
Uwe Kleine-König, Software Engineer
Digi International GmbH Branch Breisach, Küferstrasse 8, 79206 Breisach, Germany
Tax: 315/5781/0242 / VAT: DE153662976 / Reg. Amtsgericht Dortmund HRB 13962
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/