Re: [PATCH] on memoryless node, /proc/pagetypeinfo is displayed slightly funny output. take2

From: KOSAKI Motohiro
Date: Tue Apr 29 2008 - 07:11:36 EST


> I see what you mean. The headers for a node with no populated zones looks
> a bit odd. I was briefly thrown by the check for N_HIGH_MEMORY wondering
> why it was not a check for N_NORMAL_MEMORY. A double-check showed that
> N_NORMAL_MEMORY only has meaning on CONFIG_HIGHMEM machines and a check for
> "any memory on the node" should use N_HIGH_MEMORY which is what you do.
>
> So, your patch looks correct but unfortunately it is whitespace-damaged
> and would not apply as-is. I included a whitespace-fixed version below for
> convenience with a slightly clearer leader which I have acked.

Oops, very sorry.
I'll check my MUA settings again.

and, very thank you for your excellent cleanups.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/