Re: [PATCH 1/2] x86: mtrr cleanup for converting continuous to discrete layout v7

From: Yinghai Lu
Date: Tue Apr 29 2008 - 06:56:59 EST


On Tue, Apr 29, 2008 at 3:30 AM, Yinghai Lu <yhlu.kernel@xxxxxxxxx> wrote:
>
> On Tue, Apr 29, 2008 at 2:47 AM, Gabriel C <nix.or.die@xxxxxxxxxxxxxx> wrote:
> > Yinghai Lu wrote:
> > > some BIOS like to use continus MTRR layout, and may X driver can not add
> > > WB entries for graphical cards when 4g or more RAM installed.
> > >
> > > the patch will change MTRR to discrete.
> > >
> > > mtrr_chunk_size= could be used to have smaller continuous block to hold holes.
> > > default is 256m, could be set according to size of graphics card memory.
> > >
> > > v2: fix -1 for UC checking
> > > v3: default to disable, and need use enable_mtrr_cleanup to enable this feature
> > > skip the var state change warning.
> > > remove next_basek in range_to_mtrr()
> > > v4: correct warning mask.
> > > v5: CONFIG_MTRR_SANITIZER
> > > v6: fix 1g, 2g, 512 aligment with extra hole
> > > v7: gran_sizek to prevent running out of MTRRs.
> > >
> >
> > With this version ( and patch http://lkml.org/lkml/2008/4/29/97 ) applyed on latest linus git tree
> > the box OOPS'es early.
> >
> > Sorry I don't have time right now to write down the part of the OOPS I can see on monitor , I can try to find
> > some time later.
> >
> > In any way OOPS'es on __free_one_page+0x191/0x21e
>
> thanks. found one problem with hole_basek ...
>
> will send you v8, and hope it will be last version.

please try v8, it should get rid of the 8m entry. it need patch
http://lkml.org/lkml/2008/4/29/97 too.

Thanks

Yinghai Lu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/