Re: [patch] ACER_WMI/ASUS_LAPTOP: fix build bug

From: Len Brown
Date: Tue Apr 29 2008 - 04:31:28 EST


applied

thanks,
-len

On Tuesday 29 April 2008, Ingo Molnar wrote:
>
> randconfig testing in x86.git found the following upstream build bug:
>
> drivers/built-in.o: In function `acer_led_exit':
> acer-wmi.c:(.text+0xdc76e): undefined reference to `led_classdev_unregister'
> drivers/built-in.o: In function `acer_platform_probe':
> acer-wmi.c:(.devinit.text+0x63e6): undefined reference to `led_classdev_register'
>
> which was due to acer-wmi.o only depending on CONFIG_LEDS_CLASS, while
> also using a symbol offered by CONFIG_NEW_LEDS. Also fix a similar bug
> in CONFIG_ASUS_LAPTOP.
>
> Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
> ---
> drivers/misc/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> Index: linux/drivers/misc/Kconfig
> ===================================================================
> --- linux.orig/drivers/misc/Kconfig
> +++ linux/drivers/misc/Kconfig
> @@ -140,6 +140,7 @@ config ACER_WMI
> depends on EXPERIMENTAL
> depends on ACPI
> depends on LEDS_CLASS
> + depends on NEW_LEDS
> depends on BACKLIGHT_CLASS_DEVICE
> depends on SERIO_I8042
> select ACPI_WMI
> @@ -160,6 +161,7 @@ config ASUS_LAPTOP
> depends on ACPI
> depends on EXPERIMENTAL && !ACPI_ASUS
> depends on LEDS_CLASS
> + depends on NEW_LEDS
> depends on BACKLIGHT_CLASS_DEVICE
> ---help---
> This is the new Linux driver for Asus laptops. It may also support some
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/