Re: [patch] dvb: build failure fix

From: Ingo Molnar
Date: Mon Apr 28 2008 - 16:31:26 EST



* Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxx> wrote:

> On Mon, 28 Apr 2008 18:24:21 +0200
> Ingo Molnar <mingo@xxxxxxx> wrote:
>
> >
> > fix build failure found via x86.git randconfig testing:
> >
> > drivers/built-in.o: In function `tda829x_attach':
> > : undefined reference to `tda827x_attach'
> > drivers/built-in.o: In function `tda829x_attach':
> > : undefined reference to `tda18271_attach'
>
> > config TUNER_XC2028
> > config TUNER_MT20XX
> > config TUNER_TEA5761
> > config TUNER_TEA5767
> > config TUNER_SIMPLE
> > config TUNER_TDA9887
>
> Hmm... if the issues are with tda827x and tda18271, why have you
> touched on the above drivers? I can't see why the above tuners would
> need DVB.

ah, ok. I just copy & pasted to everything that had "depends on I2C".

> > config TUNER_TDA8290
> > tristate "TDA 8290/8295 + 8275(a)/18271 tuner combo"
> > - depends on I2C
> > + depends on I2C && ((DVB_CORE = m && m) || (DVB_CORE = y))
> > select DVB_TDA827X
> > select DVB_TDA18271
> > default m if VIDEO_TUNER_CUSTOMIZE
>
> Ok, this one may be broken.
>
> I'm working on some changes that will hopefully fix this issue at the
> proper way.

ok, great. FYI, this has been reported months ago too so it's a
long-time breakage - would be nice to fix it upstream even if it's the
initial fix is a band-aid.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/